[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: sRGB color support in NS port [PATCH]

From: Steve Purcell
Subject: Re: sRGB color support in NS port [PATCH]
Date: Thu, 26 Dec 2013 12:12:58 +0000

On 26 Dec 2013, at 09:45, Julien Danjou <address@hidden> wrote:

> On Tue, Dec 24 2013, Steve Purcell wrote:
>> Agreed. So can we please enable the new sRGB option on NS by default, then?
>> Colours won’t match between platforms with it disabled anyway, so there’s
>> nothing to lose in enabling it, and it would also help pave the way for
>> standardisation on sRGB across platforms.
> I also think it's a good idea. If you have a patch I can review and
> commit I'd be glad to do so, Steve.

Thanks to Jan’s work, it's just a matter of setting ns-use-srgb-colorspace to 
YES instead of NO in src/nsterm.m. Corresponding patch is below:

83c87170d77b1b8db17eb6a7c1f18d5e33d62e17 HEAD master
Author: Steve Purcell <address@hidden>
Date:   Thu Dec 26 12:08:20 2013 +0000

    Enable ns-use-srgb-colorspace by default

2 files changed, 2 insertions(+), 2 deletions(-)
 etc/NEWS     | 2 +-
 src/nsterm.m | 2 +-

        Modified   etc/NEWS
diff --git a/etc/NEWS b/etc/NEWS
index 5aedab6..03ea2e4 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1248,7 +1248,7 @@ Customize `ns-use-native-fullscreen' to change style.  
For >= 10.7
 native is the default.
 ** OSX >= 10.7 can use sRGB colorspace.
-Customize `ns-use-srgb-colorspace' to change style.  nil is the default.
+Customize `ns-use-srgb-colorspace' to change style.  t is the default.
 Note: This does not apply to images.
        Modified   src/nsterm.m
diff --git a/src/nsterm.m b/src/nsterm.m
index f2aef42..07f52c0 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -7648,7 +7648,7 @@ Default is t for OSX >= 10.7, nil otherwise. */);
      doc: /*Non-nil means to use sRGB colorspace on OSX >= 10.7.
 Note that this does not apply to images.            
 This variable is ignored on OSX < 10.7 and GNUStep.  Default is nil. */);
-  ns_use_srgb_colorspace = NO;
+  ns_use_srgb_colorspace = YES;
   /* TODO: move to common code */
   DEFVAR_LISP ("x-toolkit-scroll-bars", Vx_toolkit_scroll_bars,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]