emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] trunk r115918: package.el: various fixes.


From: Bastien
Subject: Re: [Emacs-diffs] trunk r115918: package.el: various fixes.
Date: Wed, 08 Jan 2014 18:40:25 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

Glenn Morris <address@hidden> writes:

>>> +  (when (assq package package-alist)
>>>      (or
>>>       (let ((pkg-descs (cdr (assq package package-alist))))
>
> This is redundant (accesses same thing twice).
>
>>>         (and pkg-descs
>>>              (version-list-<= min-version
>>>                               (package-desc-version (car pkg-descs)))))
>>>       ;; Also check built-in packages.
>>> -     (package-built-in-p package min-version)))
>>> +     (package-built-in-p package min-version))))
>
> It also seems to make the "Also check built-in packages." branch
> unreachable.

Yes, fixed, thanks.

-- 
 Bastien



reply via email to

[Prev in Thread] Current Thread [Next in Thread]