[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: trunk r115926: In preparation for the move to git, sanitize out some

From: Juanma Barranquero
Subject: Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names.
Date: Thu, 9 Jan 2014 03:13:01 +0100

On second thought, I'm not so sure that renaming emacs-bzr-version and
emacs-bzr-get-version is a good idea (though I agree with your other
changes, to remove Bazaar-specific references in docs, etc.)

The reason is that emacs-repository-version and
emacs-repository-get-version won't be true replacements for the
current variable and function. They won't contain or return data in
the same format, and I won't be able, for example, to just use
emacs-repository-version in the same way I'm using emacs-bzr-version
right now. It's not possible, because I'm using the fact that their
value started with a numerical revno (I'm doing arithmetic with that
value), which does not make sense in Git. I will be forced to change
my code, so just making emacs-bzr-version into an obsolete alias of
emacs-repository-version is misleading.

IMO it would make more sense to define new emacs-git-version and
emacs-git-get-version instances and let user code sort which one needs
to use. These function and variable are never going to be really
repository- or DVCS-independent anyway. And it's not like we're likely
to switch DVCS again in a few years...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]