[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: trunk r115926: In preparation for the move to git, sanitize out some

From: Juanma Barranquero
Subject: Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names.
Date: Thu, 9 Jan 2014 16:21:15 +0100

On Thu, Jan 9, 2014 at 4:08 PM, Eric S. Raymond <address@hidden> wrote:

> That's before putting the function alias in place, right?

No, I aliased emacs-bzr-get-version to emacs-repository-get-version
before evalling that code. The error is because (read
emacs-repository-version) will not be guaranteed to return an

> That is incorrect.  emacs-bzr-get-version will return *exactly the name thing*
> as it did before the change, *under all circumstances*.

Not true.

- Before:  => nnnn some-bzr-revid
- Now: => nnnn some-bzr-revid (because of the alias)
- In the future, *without* the alias => nil
- In the future, *with* your alias => some-git-revid

> That's right.  The old API was misdesigned; it leaked information that
> it should not.

Misdesigned or not (and it was not: it gave me useful information),
it's what it was, what still would be if you hadn't broken it. You
want to design a better API? By all means, do it. Just leave the old
one as obsolete.

> Since that can be fixed in a compatible way, it should be.

"Fixing it in a compatible way" is what I try to do, and you refuse:

- Introduce your newfangled API
- Leave the old one as obsolete.

You're "breaking it in an incompatible way", which is quite different.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]