[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Re: About the :distant-foreground face attribute

From: Jan Djärv
Subject: Re: [PATCH] Re: About the :distant-foreground face attribute
Date: Mon, 13 Jan 2014 22:29:59 +0100


13 jan 2014 kl. 19:41 skrev Daniel Colascione <address@hidden>:

> On 01/13/2014 08:33 AM, Jan Djärv wrote:
>> 13 jan 2014 kl. 14:13 skrev Daniel Colascione <address@hidden>:
>>> The patch uses the CIE L*A*B colorspace algorithm by default.
>> Do not change the defaults please. Reinstate the
>> *_selection_fg_color.
>> They are system defined and should be honored.
> There are two sane defaults: the 24.3 behavior, where we always use the 
> system selection foreground and background, and my proposed behavior, where 
> we use the fontified foreground and automatically adjust it so that it's 
> legible. The current behavior is worse because it uses the system selection 
> foreground only sometimes and doesn't preserve theme hues when possible.

What theme hues?  The default theme is not really a theme as selection colors 
are taken from system settings.  And this is correct IMHO, any application that 
doesn't do so by default (i.e. no user configuration has been set in the 
application) is seriously broken.

If you talk about other themes, they can set :distant-foreground to a real 
color of their choosing and not rely on some automatically generated one which 
most probably don't fit the theme anyway.  Automatically generated colors are a 
crutch which should be avoided if possible, certainly not recommended.

Of course the 24.3 has been changed, that default is no longer valid due to bug 
#15668 and it is pointless to use that as an argument unless you mean that the 
bug fix should be reverted.

        Jan D.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]