[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] About the :distant-foreground face attribute

From: Eli Zaretskii
Subject: Re: [PATCH] About the :distant-foreground face attribute
Date: Wed, 15 Jan 2014 17:38:20 +0200

> From: Stefan Monnier <address@hidden>
> Cc: Daniel Colascione <address@hidden>,  Eli Zaretskii <address@hidden>,  
> Chong Yidong <address@hidden>,  emacs-devel <address@hidden>
> Date: Tue, 14 Jan 2014 23:22:34 -0500
> > Well, my position is not to revert, so by doing that nobody is happy.
> > Why is that good?  Anyway, as I said before, this is Stefans call.
> > But I always assumed we are talking post-release here as your code
> > clearly don't belong in a feature freeze.  Again, Stefans call.
> In the short term, indeed, Daniel's patch is too new for 24.4.
> But in the longer term, I like the idea of being able to write Elisp
> code to fine-tune the colors.
> So the :distant-foreground might not be useful after 24.4.
> IOW, if we keep it for 24.4, I think we should hide it so we can remove
> it later.  Not sure how to do that, tho.
> What do you guys think?

How about changing just the name of the attribute for now?  We could
then keep the implementation, and after the branch extend it to accept
more flexible forms as the value of the attribute.  Then we will both
fix the original bug, and avoid the risk of introducing short-lived,
non forward-compatible attributes.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]