[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] About the :distant-foreground face attribute

From: John Yates
Subject: Re: [PATCH] About the :distant-foreground face attribute
Date: Wed, 15 Jan 2014 16:31:36 -0500

:post-merge-adjust ?
:final-adjust ?


On Wed, Jan 15, 2014 at 4:03 PM, Daniel Colascione <address@hidden> wrote:
On 01/15/2014 12:40 PM, Eli Zaretskii wrote:
From: Josh <address@hidden>
Date: Wed, 15 Jan 2014 12:05:05 -0800
Cc: Stefan Monnier <address@hidden>, Jan Djärv <address@hidden>,
        Daniel Colascione <address@hidden>, Chong Yidong <address@hidden>, emacs-devel <address@hidden>

Though this does seem likely, it might be wise to adopt a less
specific name for this attribute now in case other appropriate uses
of this adjustment mechanism later come to light.  If we were to
use a name like :attribute-filters or :attribute-adjusters we'd retain
flexibility for the future even though we might only support
adjusting foreground color initially (or indeed ever).

It has been a long tradition of Emacs not to generalize before there's
a clear and present need to.

Sure. The problem with :adjust-colors or some other specific name, though, is what happens to ordering if we introduce other kinds of filters. If we have :adjust-colors and some hypothetical :adjust-foo, the order in which the adjustments are made becomes unclear. If we have a single list of filters, ordering is natural.

Also, can we please include "post-" in the name of the attribute? I want to emphasize that the filtering happens *after* face merging.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]