[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ruby-mode] Private/protected method definition layout in Ruby 2.1

From: Dmitry Gutov
Subject: Re: [ruby-mode] Private/protected method definition layout in Ruby 2.1
Date: Thu, 16 Jan 2014 15:37:26 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

On 16.01.2014 12:15, Bozhidar Batsov wrote:
I'm OK with the patch, but it makes configuration a bit more difficult
since users should actually know all the alignable keywords.

Why? The Customize interface will still show all possible values, and if the user looks at the definition of the variable directly, they should notice the use of `ruby-alignable-keywords'.

I guess we
can mention `ruby-alignable-keywords' in the docstring
of `ruby-align-to-stmt-keywords' and consider this a good enough hint
for the users. One problem with the current implementation is that it
won't play nice with assignments if you won't to treat them differently:

Do you suggest to both apply the patch I suggested, *and* add a new user option? Because without the patch, there won't be a way to treat them "the same".

What I'm saying is that some people
might prefer to align `def` with a statement beginning only with access
modifier methods.

What I'd like to know if you personally plan to use such user option. Adapting to a hypothetical user can wait until the release of 24.4, I'd say. And it'd be better to wait until a specific feature request anyway.

> Of course, it seems unlikely that someone will assign
the value of a method def to a variable, but in the future a method
definition in MRI,

The above sentence seems to be missing something.

> but it makes sense in Rubinius for instance.

Could you explain why?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]