[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Changes in update-game-score.c

From: Paul Eggert
Subject: Re: Changes in update-game-score.c
Date: Wed, 22 Jan 2014 19:32:01 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

Eli Zaretskii wrote:
Why do we suddenly care about it so much?

We got a bug report about it, which I fixed, and I noticed some other bugs in the neighborhood, including undefined behavior and race conditions which are dicey in a setuid program (it's bad PR at the very least). A feature freeze shouldn't prevent us from fixing such bugs.

The main culprit here was the w32 port's definition of fchmod as a noop for Emacs, and its failure to define fchmod for non-Emacs executables. We can't expect non-w32 experts to anticipate that sort of tricky situation flawlessly every time.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]