[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Changes in update-game-score.c

From: Paul Eggert
Subject: Re: Changes in update-game-score.c
Date: Thu, 23 Jan 2014 13:50:56 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

On 01/23/2014 12:27 PM, Juanma Barranquero wrote:
On Thu, Jan 23, 2014 at 5:07 PM, Eli Zaretskii<address@hidden>  wrote:

>That is exactly what we all should do: each commit is one coherent
>changeset, solving a problem that is independent of others.
Very emphatically agree.

It's easy to nod one's head and say "yes, that's right! and whoever commits independent changes should be taken out and shot!". But in practice that's far too extreme. For example, if we look at a recent simple patch (attached), it's actually two changes, one change for each variable that was declared on WINDOWSNT platforms but not used there.

Now, suppose someone complained "Hey! Wait a minute! You should have broken that into two independent fixes and installed each fix separately!" I hope our response would be something like "Sure, we could have installed two separate patches. But that would have been overkill here; it would have been too much work for everybody for too little benefit." The situation for update-game-score was similar, and this is true of many changes we make to Emacs.

Attachment: windowsnt.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]