[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Changes in update-game-score.c

From: Paul Eggert
Subject: Re: Changes in update-game-score.c
Date: Fri, 24 Jan 2014 00:42:35 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

Eli Zaretskii wrote:
sumo changesets make maintenance harder

Sure, but the change that prompted this thread (trunk bzr 116113) deleted 13 lines of code and added 8. That's a small changeset, not a sumo one.

the comparison is invalid because this [other] change wasn't fixing any bug, 
it's more like whitespace cleanup.

It's easy to find bug-fixing changes that behave the same way. For example, the most recent bug-fixing patch that you installed (attached) actually consists of multiple independent changes. One change replaces fchmod with chmod on WINDOWSNT platforms, fixing a porting bug; but another change replaces "!=" with "<" on WINDOWSNT, and this change does not fix any bug.

This sort of thing happens all the time, and it's OK. It'd be unreasonable to insist that every patch to Emacs now must fix just one bug and must not make any changes that do not fix the bug.

Attachment: w32.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]