[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] trunk r116230: Fix bug #16558 with w32-shell-execute o

From: Eli Zaretskii
Subject: Re: [Emacs-diffs] trunk r116230: Fix bug #16558 with w32-shell-execute on remote file names.
Date: Sun, 02 Feb 2014 17:54:50 +0200

> From: Stefan Monnier <address@hidden>
> Date: Sun, 02 Feb 2014 10:06:37 -0500
> Cc: address@hidden
> >> >> > +     * w32fns.c (Fw32_shell_execute): Don't call file-exists-p for
> >> >> > +     DOCUMENT that is a "remote" file name, i.e. a file-handler 
> >> >> > exists
> >> >> > +     for it.  (Bug#16558)
> >> >> That means we don't call Ffile_exists_p for .gz files :-(
> >> >> It seems arbitrary.
> >> > What do you suggest? bind handlers-alist to nil?
> >> Could you describe the problem we're trying to solve?
> > What is unclear in its description in this bug report?
> I think the problem is in calling file-exists-p.

Why is that a problem?

Btw, find-file-name-handler returns nil for file-exists-p when the
file name specifies a compressed file, so I'm not sure what bothered
you in the first place.

> IIUC we use it to decide whether to pass the file to
> expand-file-name, right?

More accurately, we use it to decide whether we need an absolute file

> And the reason we do that is because some file names are "normal" and
> others refer to non-files according to some w32 feature which can map
> them to some other tools.

The reason is described in the comment: if the file name is not
absolute and its name is not relative to the directory passed to the
system API, the API will fail.  But we don't want to try to make
non-file names "absolute", since that would munge them beyond

> I don't know that w32 feature at all, so it's hard for me to figure out
> what should be done, but it seems like file-exists-p is not the right
> thing to do anyway since the file name might be "normal" but refer to
> a file that doesn't exist yet.

Yes, that might happen, but then the file will be created in a
directory other than what the user expects it to, perhaps.

> So, how does w32 decide whether a file name is "normal" or not?

We cannot know: it's up to the application that is associated with

reply via email to

[Prev in Thread] Current Thread [Next in Thread]