[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: unnecessary requirement of X11 for imagemagick in case of cygwin

From: Ken Brown
Subject: Re: unnecessary requirement of X11 for imagemagick in case of cygwin
Date: Thu, 13 Feb 2014 22:10:45 -0500
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

On 2/13/2014 10:52 AM, Mirek Kaim wrote:
i've just compiled the latest version from repo under cygwin. imagemagick 
installed from cygwin package, with all dependecies - that includes some 
X-libs, but no X server per se. emacs configured --with-w32. all i did was this:

diff --git a/configure.ac b/configure.ac
index 326d528..bc95daa 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2236,7 +2236,7 @@ if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"

-if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"; then
+#if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"; then
    if test "${with_imagemagick}" != "no"; then
      ## 6.2.8 is the earliest version known to work, but earlier versions
      ## might work - let us know if you find one.
@@ -2254,7 +2254,7 @@ if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"
        AC_CHECK_FUNCS(MagickExportImagePixels MagickMergeImageLayers)


and it works, checked with image-dired and pdf page scaling. obviously, 
imagemagick is independent from the actual gui used by emacs - as long as there 
is a gui, it makes sense to link with it. shouldn't it be then:

if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes" || test "${HAVE_W32}" = 
"yes"; then

or am i missing something? i'm not too familiar with configure and makefile 
stuff, and i never submitted a patch so i don't have an account, so feel free 
to patch that.                                        

This looks right to me, but I don't know enough about imagemagick to be able to test it thoroughly. Maybe some imagemagick expert could comment. In the meantime, I suggest you resend this as a bug report so it doesn't get forgotten.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]