[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] trunk r116779: Restore compatibility with legacy comme
Re: [Emacs-diffs] trunk r116779: Restore compatibility with legacy comment-start-skip values
Mon, 17 Mar 2014 14:14:29 -0400
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)
>>> + (save-excursion
>>> + (forward-char -1)
>>> + (looking-at comment-start-skip)))
>> This needs to additionally check that (match-end 1) points to what we
>> thought was the comment start.
> Can you think of a situation when that's not true?
"Think of", no. But I can make one up, if you want ;-)
BTW, the new code still will fail to match the ";hello" comment in
Maybe we should use narrow-to-region to get the ^ part of the regexp to
match at point.
> And suppose it doesn't, then what?
Admittedly, I'm not sure how to handle the more general case where
comment-start-skip uses sub-group 1 for something more significant than
to rule out an escape char.