[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Not a regression, but shuld go into emacs-24

From: Jan Djärv
Subject: Not a regression, but shuld go into emacs-24
Date: Sun, 01 Jun 2014 12:43:32 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0


Jump-scrolling with Gtk+ scrollbars does not work with emacs 24 or 23.
Previously a left click on the through jumped one page forward or backwards.
A middle click on the through jumped to the place where the click was made.
A right click did nothing.

Or that was the intention. It turns out that jumping probably never has worked with Gtk+. The situation is now more pronounced as Gtk+ 3 at some point changed the meaning of
left click (previously page scroll, now jump)
middle click (previously jump, now does nothing)
and right click (previously did nothing, now does page scroll).

I would therefore like to commit this to the emacs-24 brach, even if the error is also present in emacs-23:

=== modified file 'src/xterm.c'
--- src/xterm.c 2014-05-29 16:47:49 +0000
+++ src/xterm.c 2014-06-01 10:36:07 +0000
@@ -4460,6 +4460,7 @@
           part = scroll_bar_handle;
           whole = gtk_adjustment_get_upper (adj) -
             gtk_adjustment_get_page_size (adj);
+          position = value;
           portion = min ((int)position, whole);
           bar->dragging = portion;


        Jan D.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]