Re: Changes in frame/window code

[Dmitry Antipov]

On 07/22/2014 05:42 PM, martin rudalics wrote:

> (2) Fix the "toolbar/menubar height is part of the frame text height"
>      issue (which the recent change in revision 117561 doesn't).

What's wrong with that?

> (4) Add horizontal scroll bars for the Gtk/Motif/Lucid/Windows builds.
>
> Kindly refrain from substantial frame/window code changes in the next
> few days to make the transition as smooth as possible.  And, obviously,
> please try the patch.

0) Debug stubs (Vmy_debug_it in widget.c)?

1) It doesn't even compile with --enable-gcc-warnings (didn't you use it for
   development?) due to missing 'x_clear_under_internal_border' prototype.

2) It crashes with both Lucid and Motif (after a few attempts to toggle
   with M-x horizontal-scroll-bar-mode and drag):

#0  0x000000379220f62b in raise (sig=6) at 
../nptl/sysdeps/unix/sysv/linux/pt-raise.c:37
#1  0x000000000056bcbc in terminate_due_to_signal (sig=6, 
backtrace_limit=2147483647) at ../../trunk/src/emacs.c:387
#2  0x00000000005f406d in die (msg=0x70acfe "VECTORLIKEP (a)", file=0x70acb8 
"../../trunk/src/lisp.h", line=866)
    at ../../trunk/src/alloc.c:7102
#3  0x0000000000566ba5 in XVECTOR (a=...) at ../../trunk/src/lisp.h:866
#4  0x0000000000538106 in xt_action_hook (widget=0xd10060, client_data=0x0, 
action_name=0x138e2ec "EndScroll", event=0x7fffd5134100,
    params=0x0, num_params=0x372f066290 <dummyAction.9840+16>) at 
../../trunk/src/xterm.c:4248
#5  0x000000372ee48cae in HandleActions (address@hidden, event=0x7fffd5134100, 
accelWidget=<optimized out>, procs=0xdc71d8,
    address@hidden <dummyAction.9840>, stateTree=<optimized out>) at 
TMstate.c:634
#6  0x000000372ee49114 in HandleSimpleState (address@hidden, address@hidden,
    address@hidden) at TMstate.c:884
#7  0x000000372ee49f7c in _XtTranslateEvent (address@hidden, address@hidden) at 
TMstate.c:1101
#8  0x000000372ee22233 in XtDispatchEventToWidget (address@hidden, 
address@hidden) at Event.c:906
#9  0x000000372ee22950 in _XtDefaultDispatcher (event=0x7fffd5134100) at 
Event.c:1367
#10 0x000000372ee22a29 in XtDispatchEvent (event=0x7fffd5134100) at Event.c:1423
#11 0x000000000053eb04 in handle_one_xevent (dpyinfo=0x1363710, 
event=0x7fffd5134100, finish=0x7fffd51341cc,
    hold_quit=0x7fffd51341f0) at ../../trunk/src/xterm.c:7583
#12 0x000000000053ed7c in XTread_socket (terminal=0xf68fc8, 
hold_quit=0x7fffd51341f0) at ../../trunk/src/xterm.c:7682
#13 0x000000000057d88d in gobble_input () at ../../trunk/src/keyboard.c:6871
#14 0x000000000057de06 in handle_async_input () at 
../../trunk/src/keyboard.c:7123
#15 0x000000000057de25 in process_pending_signals () at 
../../trunk/src/keyboard.c:7137
#16 0x000000000057de64 in unblock_input_to (level=0) at 
../../trunk/src/keyboard.c:7152
#17 0x000000000057de87 in unblock_input () at ../../trunk/src/keyboard.c:7171
#18 0x00000000006c2ae7 in xg_select (fds_lim=7, rfds=0x7fffd5134b00, 
wfds=0x7fffd5134a80, efds=0x0, timeout=0x7fffd5134a60,
    sigmask=0x0) at ../../trunk/src/xgselect.c:151
#19 0x000000000066c9a5 in wait_reading_process_output (time_limit=30, nsecs=0, 
read_kbd=-1, do_display=true, wait_for_cell=...,
    wait_proc=0x0, just_wait_proc=0) at ../../trunk/src/process.c:4595
#20 0x0000000000422a40 in sit_for (timeout=..., reading=true, display_option=1) 
at ../../trunk/src/dispnew.c:5752
#21 0x0000000000573fb6 in read_char (commandflag=1, map=..., prev_event=..., 
used_mouse_menu=0x7fffd513536f, end_time=0x0)
    at ../../trunk/src/keyboard.c:2799
#22 0x0000000000582e6e in read_key_sequence (keybuf=0x7fffd5135550, bufsize=30, 
prompt=..., dont_downcase_last=false,
    can_return_switch_frame=true, fix_current_buffer=true, 
prevent_redisplay=false) at ../../trunk/src/keyboard.c:9120
#23 0x000000000057064b in command_loop_1 () at ../../trunk/src/keyboard.c:1438
#24 0x0000000000612373 in internal_condition_case (bfun=0x570289 <command_loop_1>, 
handlers=..., hfun=0x56fa59 <cmd_error>)
    at ../../trunk/src/eval.c:1347
#25 0x000000000056ff27 in command_loop_2 (ignore=...) at 
../../trunk/src/keyboard.c:1169
#26 0x00000000006117f6 in internal_catch (tag=..., func=0x56ff04 
<command_loop_2>, arg=...) at ../../trunk/src/eval.c:1111
#27 0x000000000056fedb in command_loop () at ../../trunk/src/keyboard.c:1148
#28 0x000000000056f585 in recursive_edit_1 () at ../../trunk/src/keyboard.c:769
#29 0x000000000056f755 in Frecursive_edit () at ../../trunk/src/keyboard.c:840
#30 0x000000000056d65c in main (argc=2, argv=0x7fffd51359d8) at 
../../trunk/src/emacs.c:1650

3) On Lucid, scroll bars are of the different colors (see screenshot).

Dmitry

lucid.png
Description: PNG image