[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] ImageMagick Support on Windows

From: Eli Zaretskii
Subject: Re: [Emacs-diffs] ImageMagick Support on Windows
Date: Mon, 13 Oct 2014 12:29:21 +0300

> From: Alexander Shukaev <address@hidden>
> To: address@hidden
> Date: Mon, 13 Oct 2014 10:55:41 +0200
> Recently I've written to another list that I would be preparing high-quality
> feature-rich 32-bit and 64-bit builds of Emacs for Windows in 2 variants:
> standalone and as MSYS2 package. Here is my first patch to allow dynamic
> linking with ImageMagick runtimes.


First, please send patches either to address@hidden or
address@hidden  The emacs-diffs list is not normally used for
discussions, it is where the diffs from commits are sent by the VCS.

Now about your patch: in a nutshell, it misses a few more bits
necessary to get ImageMagick support in Emacs to work well on
Windows.  The missing parts are:

 . configure.ac needs changes to revert IMAGEMAGICK_LIBS to empty
   value, because otherwise src/Makefile will cause Emacs binary to be
   linked against the ImageMagick libraries, and the resulting binary
   will then refuse to start if the corresponding DLL is not available
   at run time.  You can see the example of how we do that with

 . dynamic-library-alist in w32-win.el should acquire an element
   required for Emacs to know which DLL(s) to look for when
   ImageMagick support is first required.

 . If there are several ImageMagick versions out there whose DLLs are
   not binary compatible, you will need to add version checking, both
   on init_imagemagick_functions and in dynamic-library-alist,
   similarly to what we already do with some other image libraries,
   like libgif, libjpeg, etc.

Thanks again for working on this.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]