[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Possibility of a ${srcdir}/info/dir target race?

From: Paul Eggert
Subject: Re: Possibility of a ${srcdir}/info/dir target race?
Date: Wed, 22 Oct 2014 23:36:08 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0

Glenn Morris wrote:
Surely the actual relevant change is only to add ${MKDIR_P}
${srcdir}/info, which could easily have been applied to emacs-24, only
it's mixed in with unrelated performance improvements?

I didn't bother, because I didn't think any part of the change should be applied to emacs-24. As you mentioned, an 'info' dir shouldn't go missing with any normal use of an Emacs distribution tarball. The Debian build process is quite specialized and surely the Debian folks can get it to work themselves, e.g., by doing a "mkdir info" after the "make bootstrap-clean" (or better yet, omit the bootstrap-clean).

Similar constructs have been used for years in eg lisp/Makefile.in
lisptagsfiles etc.

Ah, sorry, I was wrong about the wildcards. I didn't know that GNU make expanded wildcards in prerequisites. So that part of the change didn't fix any bugs (though the use of the 'wildcard' function is still helpful). I have fixed the corresponding ChangeLog entry accordingly, in trunk bzr 118182. That bzr also removes a couple of other calls to 'wildcard' that were present only because of the same misunderstanding of how wildcards work in prerequisites.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]