[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] sequence manipulation functions

From: Daniel Colascione
Subject: Re: [PATCH] sequence manipulation functions
Date: Fri, 07 Nov 2014 17:43:07 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0

On 11/07/2014 05:35 PM, Nicolas Petton wrote:
> Hi,
> Here is a patch containing the new version of sequences.el and its
> associated test file

Why do you want to dump these functions with Emacs?

> +(defun seq-sort (seq pred)
> +  "Return a sorted list of the elements of SEQ compared using PRED."
> +  (if (listp seq)
> +      (sort (seq-copy seq) pred)
> +    (seq-sort (append seq nil) pred)))

If you insist on adding seq- prefixed functions (and I don't think you
should, contra rms), you should make an alias, not a wrapper. You're
aware that we have native sort support for vectors and don't to coerce
to a list first, right?

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]