[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: History for query replace pairs

From: Stefan Monnier
Subject: Re: History for query replace pairs
Date: Sun, 09 Nov 2014 17:14:08 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux)

> +  (propertize
> +   "\0"
> +   'display (propertize
> +          (if (and
> +               ;; Don't call char-displayable-p while pre-loading replace.
> +               (not (equal (car preloaded-file-list) "replace"))
> +               (char-displayable-p ?\u2192)) " \u2192 " " -> ")
> +          'face 'minibuffer-prompt)
> +   'separator t)

I think the (propertize "\0" ... 'separator t) wrapper should *not*
be customizable.

And making the arrow cutomizable seems like a bad idea anyway, just
pushing the problem onto the user.

The (not (equal (car preloaded-file-list) "replace")) test makes
no sense.  Why don't we want to call char-displayable-p while
pre-loading replace?  Shouldn't we instead test (fboundp 'char-displayable-p)
or simply wrap the code in ignore-errors (if the problem is that
char-displayable-p fails when run without a real frame at hand, which
might also happen in daemon mode)?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]