[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Request for Mentor] subst-char-in-region

From: Stefan Monnier
Subject: Re: [Request for Mentor] subst-char-in-region
Date: Fri, 12 Dec 2014 09:35:16 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

> ooo
> bbb

> Changing ooo to xxx reports the following from Emacs

> before(1,8)
> after(1,4,3)

That looks correct to me.

> origin/fix/subst-char-in-region
> (hopefully adding a new branch is okay for this, obviously it can be
> deleted later). After adding this fix I get...

Please use "scratch/<foo>" rather than "fix/<foo>".

> before(1,8)
> after(1,8,8)

This wouldn't be wrong, but would be less precise.

> Assuming others agree with me that this behaviour is wrong, I would like
> to fix the problem, but would welcome some help and code review.

Assuming a close&direct correct correspondence between
before-change-functions and after-change-functions is just a bad idea.
Does you code *really* need that?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]