[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] scratch/bug19328/custom-prompt-customize-unsaved-optio
From: |
Stefan Monnier |
Subject: |
Re: [Emacs-diffs] scratch/bug19328/custom-prompt-customize-unsaved-options-rc2 e9e8f01: Provide custom-prompt-customize-unsaved-options. |
Date: |
Sun, 14 Dec 2014 09:36:00 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
Looks good, with the following nitpicks
> * lisp/cus-edit.el (custom-prompt-customize-unsaved-options): Add a
> mechanism for prompting user about unsaved customizations.
These two lines mean "change the custom-prompt-customize-unsaved-options
by adding a mechanism for ...", which is not what the patch does.
Instead, they should just say
* lisp/cus-edit.el (custom-prompt-customize-unsaved-options): New function.
Additionally, this text fails to mention custom-unsaved-options or the
fact that customize-unsaved has been modified, so I'd write:
* lisp/cus-edit.el (custom-unsaved-options): New function, extracted
from customize-unsaved.
(custom-unsaved): Use it.
(custom-prompt-customize-unsaved-options): New function.
Feel free to install it, thank you,
Stefan
- Re: [Emacs-diffs] scratch/bug19328/custom-prompt-customize-unsaved-options-rc2 e9e8f01: Provide custom-prompt-customize-unsaved-options.,
Stefan Monnier <=