Re: [Emacs-diffs] master f7572b7: Fix Semantic completion-at-point functions in non-Semantic buffers

[Dmitry Gutov]

On 12/14/2014 04:30 PM, Stefan Monnier wrote:
> >      * lisp/cedet/semantic.el (semantic-analyze-completion-at-point-function)
> >      (semantic-analyze-notc-completion-at-point-function)
> >      (semantic-analyze-nolongprefix-completion-at-point-function): Do
> >      nothing if the current buffer is not using Semantic.
>
> Looks like the wrong fix.  Don't you think the right fix would be to
> change the add/remove-hooks in semantic-mode so that they are
> buffer-local?

`semantic-mode' is global, so it's easier to have these hooks globally 
too. I guess we can move the changing of hooks to 
`semantic-new-buffer-fcn', but I don't see its counterpart which would 
run when `semantic-mode' is being disabled.