[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master f7572b7: Fix Semantic completion-at-point funct

From: Dmitry Gutov
Subject: Re: [Emacs-diffs] master f7572b7: Fix Semantic completion-at-point functions in non-Semantic buffers
Date: Sun, 14 Dec 2014 16:38:27 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0

On 12/14/2014 04:30 PM, Stefan Monnier wrote:
     * lisp/cedet/semantic.el (semantic-analyze-completion-at-point-function)
     (semantic-analyze-nolongprefix-completion-at-point-function): Do
     nothing if the current buffer is not using Semantic.

Looks like the wrong fix.  Don't you think the right fix would be to
change the add/remove-hooks in semantic-mode so that they are

`semantic-mode' is global, so it's easier to have these hooks globally too. I guess we can move the changing of hooks to `semantic-new-buffer-fcn', but I don't see its counterpart which would run when `semantic-mode' is being disabled.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]