[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] scratch/bug19328/custom-prompt-customize-unsaved-optio

From: Ted Zlatanov
Subject: Re: [Emacs-diffs] scratch/bug19328/custom-prompt-customize-unsaved-options-rc2 e9e8f01: Provide custom-prompt-customize-unsaved-options.
Date: Sun, 14 Dec 2014 12:09:07 -0500
User-agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux)

On Sun, 14 Dec 2014 09:36:00 -0500 Stefan Monnier <address@hidden> wrote: 

SM> Looks good, with the following nitpicks
>> * lisp/cus-edit.el (custom-prompt-customize-unsaved-options): Add a
>> mechanism for prompting user about unsaved customizations.

SM> These two lines mean "change the custom-prompt-customize-unsaved-options
SM> by adding a mechanism for ...", which is not what the patch does.
SM> Instead, they should just say

SM>   * lisp/cus-edit.el (custom-prompt-customize-unsaved-options): New 

SM> Additionally, this text fails to mention custom-unsaved-options or the
SM> fact that customize-unsaved has been modified, so I'd write:

SM>   * lisp/cus-edit.el (custom-unsaved-options): New function, extracted
SM>   from customize-unsaved.
SM>   (custom-unsaved): Use it.
SM>   (custom-prompt-customize-unsaved-options): New function.

OK, I installed it earlier and have now added a commit to just fix that
ChangeLog entry.

FWIW, I think your version does not explain what the change provides,
only that it was made (it basically restates the diff).  I don't know if
that's what you intended.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]