emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Generalizing find-definition


From: Dmitry Gutov
Subject: Re: Generalizing find-definition
Date: Mon, 15 Dec 2014 23:24:40 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.51 (gnu/linux)

Stefan Monnier <address@hidden> writes:

>> When it's t, the function would return an approximate string (basically
>> symbol at point, but maybe with minor syntax adjustments), and that
>> value would be used both in the error message (when we can't find
>> anything), and as initial input for identifier completion, from
>> xref-identifier-completion-table.
>
> I don't care about which values are really allowed as identifiers.
> I just the docstring to say clearly that non-strings can be used.
> And I'd like to get rid of the "identifier->string" method because
> I think it's over-engineering (it's only used to give
> very-slightly-prettier error messages).

The message you're responding to assumes familiarity with the patch,
which, I think, already addresses both your points (and identifiers can
only be strings, nil or t, like you suggested before).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]