[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: image-transform.el and image-mode.el rewrite

From: Vitalie Spinu
Subject: Re: image-transform.el and image-mode.el rewrite
Date: Thu, 18 Dec 2014 13:32:57 -0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

 >>> Michael Heerdegen on Thu, 18 Dec 2014 15:17:01 +0100 wrote:

 > Some comments:

 > - When I visit an image file, `image-manipulation-map' doesn't seem to be
 >   installed.  E.g. "+" is not working etc.  OTOH when I hit C-c C-c two
 >   times, it works then.  Is this expected?

It should work at start. You should see a Manipulate menu and all the
keys from `image-manipulate-map` must be active. It works for me on

 > - I think it would be good when there would be entries in the
 > "Manipulate" menu (defined in `image-manipulation-map') for
 > increasing and decreasing the image size.

Good point.

 > - I see some warnings about unused lexical variables.  I think some are
 >   concerning pcase (where you probably need to prefix unused vars with
 >   underscore in some patterns), but there are also some concerning
 >   function arguments.
 > - And there are some warnings about using cl functions at runtime.  I
 >   guess Emacs maintainers will want you to use only cl-lib?

Sure, I am fixing these.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]