Re: dired: make dired-maybe-insert-subdir always skip trivial files

[Juri Linkov]

> When `dired-maybe-insert-subdir' is called on a subdir not yet present
> in the dired buffer, it inserts that subdir and skips to a first
> "non-trivial" file.
>
> But when it is already present, the point jumps to the header line and
> stays there.
>
> Below is the fix which makes it select the first non-trivial file
> always.  Is it ok to apply?

I agree it would be good to make it consistent for both cases:
when it is already present and not present, especially good after fixing
http://debbugs.gnu.org/19436

> -          (dired-goto-subdir dirname))
> +          (when (dired-goto-subdir dirname)
> +            (unless (dired-subdir-hidden-p dirname)
> +              (dired-initial-position dirname))
> +            t))

Why do you always return t?  Wouldn't it be better to use something like
(prog1 (dired-goto-subdir dirname) (unless ...))