[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets
From: |
joakim |
Subject: |
Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets |
Date: |
Thu, 05 Feb 2015 16:54:55 +0100 |
User-agent: |
Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) |
Paul Eggert <address@hidden> writes:
> address@hidden wrote:
>> I'm guessing gnu indent breaks some Emacs build macrology.
>
> Yes, GNU indent doesn't understand DEFUN or DEFVAR_LISP. Those, you
> need to reindent by hand. Please see the patch in my earlier message
> for a good style for doing that, at:
>
> http://lists.gnu.org/archive/html/emacs-devel/2015-02/msg00012.html
>
> That patch also contains several other ideas worth considering. If
> you don't understand any part of that patch please ask.
>
Is it possible to somehow regenerate your patch against whats in the
xwidget branch now?
I fixed a number of things, including using gnu indent, and the src has
now diverged from the state of your patch.
If its not possible to regenerate the patch I will work through it by
hand.
Some questions on the patch though:
- Are you supposed to have a space after # on ifdefed macros?
- you mentioned some names are long, I suppose like
webkit_osr_mime_type_policy_typedecision_requested_callback
These are generated algorithmically from signal names. Do you have an
idea for another algorithm?
--
Joakim Verona
- Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets, (continued)
- Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets, joakim, 2015/02/01
- Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets, Dmitry Gutov, 2015/02/01
- Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets, David Engster, 2015/02/01
- Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets, Dmitry Gutov, 2015/02/01
- Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets, David Engster, 2015/02/01
- Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets, joakim, 2015/02/03
- Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets, Paul Eggert, 2015/02/03
- Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets, joakim, 2015/02/04
- Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets, joakim, 2015/02/04
- Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets, Paul Eggert, 2015/02/04
- Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets,
joakim <=
- Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets, Paul Eggert, 2015/02/05
- Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets, joakim, 2015/02/09
- Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets, joakim, 2015/02/09
- Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets, Paul Eggert, 2015/02/09
- Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets, joakim, 2015/02/09
- Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets, Paul Eggert, 2015/02/09
- Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets, joakim, 2015/02/10
Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets, Eli Zaretskii, 2015/02/01