[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix tramp test
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH] Fix tramp test |
Date: |
Sun, 22 Feb 2015 18:00:44 +0200 |
> From: Michael Albinus <address@hidden>
> Date: Sun, 22 Feb 2015 15:14:57 +0100
> Cc: address@hidden
>
> > A tiny patch for a test that fails in non English systems. OS output
> > summary is
> > language dependent and for example in Polish it displays "razem 1234"
> > instead of
> > "total 1234".
> >
> > Please let me know if it can't be applied for some reason.
> >
> > diff --git a/test/automated/tramp-tests.el b/test/automated/tramp-tests.el
> > index 2c4610c..e60a13f 100644
> > --- a/test/automated/tramp-tests.el
> > +++ b/test/automated/tramp-tests.el
> > @@ -955,7 +955,7 @@ This tests also `file-directory-p' and
> > `file-accessible-directory-p'."
> > (looking-at-p
> > (concat
> > ;; There might be a summary line.
> > - "\\(total.+[[:digit:]]+\n\\)?"
> > + "\\([[:alpha:]].+[[:digit:]]+\n\\)?"
>
> Better might be "\\([[:alpha:]]+[[:blank:]]+[[:digit:]]+\n\\)?"
IMO, [:alpha:] is too indiscreet: it will match almost anything,
except in pure ASCII range. Including some error message, for
example.
So I think it would be much better to keep the literal "total", and
instead set LC_MESSAGES=en_US.UTF-8, or something similar.
- [PATCH] Fix tramp test, Przemysław Wojnowski, 2015/02/22
- Re: [PATCH] Fix tramp test, Michael Albinus, 2015/02/22
- Re: [PATCH] Fix tramp test,
Eli Zaretskii <=
- Re: [PATCH] Fix tramp test, Michael Albinus, 2015/02/22
- Re: [PATCH] Fix tramp test, Eli Zaretskii, 2015/02/22
- Re: [PATCH] Fix tramp test, Michael Albinus, 2015/02/22
- Re: [PATCH] Fix tramp test, Przemysław Wojnowski, 2015/02/22
- Re: [PATCH] Fix tramp test, Andreas Schwab, 2015/02/22
- Re: [PATCH] Fix tramp test, Michael Albinus, 2015/02/22
- Re: [PATCH] Fix tramp test, Eli Zaretskii, 2015/02/22