emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: add-hook and defvar


From: Philipp Stephani
Subject: Re: add-hook and defvar
Date: Fri, 06 Mar 2015 19:05:58 +0000

Ack. Modified patch attached.

Btw, do I still need to write explicit changelog entries or is that already done automatically?
Artur Malabarba <address@hidden> schrieb am Do., 5. März 2015 um 22:45 Uhr:
This should probably do the same if the variable name ends with
"-functions" (since IIUC that's the correct way of naming a hook where
the functions should take arguments).

2015-03-05 17:28 GMT-03:00 Philipp Stephani <address@hidden>:
>
>
> Stefan Monnier <address@hidden> schrieb am Mi., 25. Feb. 2015 um
> 03:56 Uhr:
>
>> > Is this something the byte compiler could warn about? At least normal
>> > hooks
>> > by convention end in "-hook", so a warning could be emitted every time
>> > such
>> > a variable is defined that doesn't have nil as default.
>>
>> Yes, we could do that.  Patch welcome,
>>
>>
>
> Added a patch.

Attachment: 0001-Warn-if-a-hook-variable-is-given-a-non-nil-init-form.txt
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]