emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Requesting patch review


From: Thien-Thi Nguyen
Subject: Re: Requesting patch review
Date: Sun, 08 Mar 2015 09:16:52 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

() Jackson Hamilton <address@hidden>
() Sat, 7 Mar 2015 18:09:01 -0800

   +    * lisp/progmodes/js.el (js--proper-indentation): Add and use new
   +    custom option `js-dynamic-multi-line-declaration-indentation'.

I haven't looked at the code; this comment is on the ChangeLog,
which mentions ‘js-dynamic-multi-line-declaration-indentation’
(good), but in the wrong place (bad).  Better something like:

 * lisp/progmodes/js.el
 (js-dynamic-multi-line-declaration-indentation): New custom option.
 (js--proper-indentation): Use it.

That's admittedly more ugly, but maybe that could be a reason to
find a more concise name for the new custom option...

-- 
Thien-Thi Nguyen
   GPG key: 4C807502
   (if you're human and you know it)
      read my lisp: (responsep (questions 'technical)
                               (not (via 'mailing-list)))
                     => nil

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]