Re: [Emacs-diffs] master f469024: Use delete-char instead of delete-backward-char.

[Vibhav Pant]

Sorry for that, I'll send a patch soon.

On 19 March 2015 8:48:04 am IST, Stefan Monnier <address@hidden> wrote:

     * lisp/leim/quail/hangul.el
     * lisp/progmodes/cperl-mode.el: Use delete-char instead of
     delete-backward-char, fixes compilation warnings.

The above doesn't use the right syntax.  The right syntax looks like

  * <filename> (<functionname>): blabla.

IOW you need to add the function names.
Please re-read https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs

 @@ -2588,7 +2588,7 @@ Will untabify if `cperl-electric-backspace-untabify' is non-nil."
     (delete-region (point) p))
        (if
cperl-electric-backspace-untabify
     (backward-delete-char-untabify arg)
 - (delete-backward-char arg)))))
 + (delete-char (- arg))))))

This doesn't look right: I think here we do want to run
delete-backward-char since this is part of a command which basically
extends the normal binding of DEL which is delete-backward-char.
Maybe we should call it interactively, tho.


        Stefan

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.