emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 1fcc552: lisp/gnus/registry.el (registry-prune)


From: Eric Abrahamsen
Subject: Re: [Emacs-diffs] master 1fcc552: lisp/gnus/registry.el (registry-prune): Allow registry to reach full size before pruning
Date: Sat, 21 Mar 2015 09:32:27 +0800
User-agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux)

Stefan Monnier <address@hidden> writes:

>> +    (if (> size (oref db :max-size))
>
> Why do people use the :initarg rather than the slot name?
>
>    (oref db max-size)
>
> works as well (actually better: it's implemented more efficiently).

Because we didn't know any better! For some value of "us"...

I saw your recent patch to the registry files, but you only changed
*some* of the calls to oref/oset to use slot names. That was confusing.
I can change the rest of them over, if that's desirable.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]