[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Organizing package.el a bit

From: Artur Malabarba
Subject: Re: Organizing package.el a bit
Date: Sun, 29 Mar 2015 13:56:33 +0100

Nevermind, the test fails on master for me as well.

2015-03-29 12:06 GMT+01:00 Artur Malabarba <address@hidden>:
> I just pushed a proposal for this (using page-breaks, not separate
> files) into scratch/organizing-package.el, but if people don't want me
> to do the reorganization, I'll just delete the branch and forget about
> it.
> The branch is just a bunch of moving around. The only code change is
> on the first commit, it moves `package-version-join' to subr.el (with
> the other version-* functions) under the name `version-join'.
> Oddly, it's causing the test `file-notify-test03-autorevert-remote' to fail.
> 2015-03-29 10:04 GMT+01:00 Steinar Bang <address@hidden>:
>>>>>>> Artur Malabarba <address@hidden>:
>>> I'd like to know whether it's ok to split it into two files,
>>> package.el and package-menu.el?
>>> The distinction is very logic, there's a ton of stuff that goes on in
>>> package.el which doesn't make any use of the package-menu.
>>> The only downside of this refactoring would be to mess up things like
>>> `git-blame`, and that's why I'm askinghere.
>> If you do
>>  cp package.el package-menu.el
>>  git add package-menu.el
>>  git commit -m "Copying verbatim to preserve history"
>> before you start working, and then do your changes by removing stuff
>> from package-menu.el (and package.el) and not move things around
>> otherwise, then git-blame should show the correct history.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]