[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 4e23cd0 4/5: * mail/rmail.el (rmail-show-messag

From: Eli Zaretskii
Subject: Re: [Emacs-diffs] master 4e23cd0 4/5: * mail/rmail.el (rmail-show-message-1): When displaying a mime message,
Date: Wed, 08 Apr 2015 09:36:00 +0300

> Date: Tue, 7 Apr 2015 20:11:14 +0000
> Cc: address@hidden, address@hidden
> From: Alan Mackenzie <address@hidden>
> Small point: one of the examples commits a ChangeLog, which as from
> today, we don't do any more.


> Bigger point: the workflow depicted implicitly assumes that _all_
> changes made to files are to be committed in one commit action.  I think
> it would be better if this was stated explicitly, with a sentence like
> "The following commands assume _all_ the changes you have made to any
> files will be committed together." immediately under the heading "Daily
> Work".

Added a note to that effect.

> I actually use git stash rather than commits with messages like "Commit
> to allow pull from upstream."; I find it the lesser of two evils - I
> don't think one should have to commit unnaturally because of constraints
> in the tools.  I think the sub-workflow git stash; git pull; git stash
> pop might be worth mentioning.


> It might be useful to mention "git checkout foo.el" as doing what we
> used to know as "bzr revert foo.el", perhaps under the "If you made a
> mistake" section.  I remember I had to ask for this command on
> emacs-devel, once.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]