[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Dynamic loading progress

From: Ted Zlatanov
Subject: Re: Dynamic loading progress
Date: Tue, 21 Apr 2015 10:14:43 -0400
User-agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux)

On Tue, 21 Apr 2015 10:58:06 +0200 Aurélien Aptel <address@hidden> wrote: 

AA> On Tue, Apr 21, 2015 at 1:38 AM, Ted Zlatanov <address@hidden> wrote:
>> I like it. Can you provide a simple example in the branch of how it
>> would be used from both sides? I can restart the testing and keep it in
>> sync with the Emacs repo again.

AA> It's already in there:



As far as the coding style and barriers this enforces, I think it's just
right.  Thanks to you and Dan Colascione and the others for working on it.

As far as capabilities, the basic module should have a string exchange,
as you've started to implement in `copy_string_contents'
and `make_string'.  I think it's impossible to move forward without that.

I would go simple for now: always make a copy of the string using UTF-8
encoding in the args, assuming that the majority of C modules can deal
with it, and we can stop worrying about string sharing and encoding for
now (we can revisit them later). We should free the copy right after
calling so the module doesn't have to free it.

If you agree, maybe you should make a specific type for UTF-8 encoded
strings so we can support others in the future (byte array, wchars,

I think `plugin_is_GPL_compatible' should be a float indicating the GPL
version.  Maybe even a char[] to express flavors, from a constrained set
of choices.

Let me know what you think.  I'll hold off pushing and testing for now
but am happy to proceed on your command.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]