[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix browse-url not working when browse-url-browser-function
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH] Fix browse-url not working when browse-url-browser-function is a list (regexp . function) pairs |
Date: |
Sat, 25 Apr 2015 19:28:47 +0300 |
> From: address@hidden
> Date: Sat, 25 Apr 2015 21:44:29 +0530
>
> Are there any objections to the patch?
But the way browse-url-browser-function is documented, it should be a
list of conses, not a list of lists. With your change, if
browse-url-browser-function is an alist, like the doc string implies,
the function will now fail. So other users out there might suffer.
I'd be okay with a backward compatible change that would work with
both forms, but such a change will have to be accompanied by a
suitable change in documentation.
Thanks.