[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 8b7e2c4: python.el: Fix warnings on looking-bac

From: Stefan Monnier
Subject: Re: [Emacs-diffs] master 8b7e2c4: python.el: Fix warnings on looking-back calls missing LIMIT
Date: Thu, 30 Apr 2015 02:41:15 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

> -        (when (looking-back regexp)
> +        (when (looking-back regexp (point-min))

BTW, I didn't apply this myself when I cleaned up various other
occurrences of the looking-back warning, because I didn't know what
better value to put there than `point-min'.

Having `point-min' here means that we will sometimes stupidly search for
the regexp all the way to point-min, which can introduce
serious inefficiencies.  Of course, that's how the code has always
worked, but the purpose the making the second arg explicit is to call
the attention to this problem.

So, here's the question: is `point-min' really the best we can do here?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]