Re: [Emacs-diffs] master c4151eb: Improve the optional translation of quotes

[Paul Eggert]

Dmitry Gutov wrote:

> > substitute-command-keys has never been idempotent.
>
> Shouldn't we try not to make things worse?

I don't see the point.  Code should never invoke substitute-command-keys on the 
output of substitute-command-keys; the function is not designed that way. 
That's always been true.  It's not "making things worse" to rely on a property 
that's been in Emacs for ages.

> > If I understand you correctly, curved quotes will normally be kept in
> > destination strings so it should be OK.
>
> They would make little no to sense in the source strings. Have you read this
> subthread?
>
> http://lists.gnu.org/archive/html/emacs-devel/2015-06/msg00358.html

Yes, I've been reading and participating in these subthreads.  I don't follow 
your point here, though.  Normally, curved quotes pass through 
substitute-command-keys unchanged.  This is simple and intuitive and is what 
Emacs has always normally done.  Perhaps we'll come up with a better way to 
highlight the output of substitute-command-keys at some point, a way that treats 
quotes and key substitutions differently.  That might be nice, but it's not 
clear how it would work exactly, and in the meantime we have a simple approach 
that does work.