Re: [PATCH] ; Do not overwrite prexisting contents of unread-command-events

[David Kastrup]

David Kastrup <address@hidden> writes:

> Unfortunately, recording macros with C-x ( ... C-x ) and replaying with
> C-x e is still bleeding probably something like 15% of my events
> synthesized from Midi when pressing chord buttons on an accordion
> (3 immediately adjacent Midi events taking something like 2 bytes each
> at 31250 bits/s, read in via an Emacs process filter function).
>
> So the output of C-x e is somewhat shorter than the equivalent when
> recording.
>
> I suspect that code of the form
>
> (let (unread-command-events)
>    ...
>  )
>
> in the macro recording is at fault by letting material arrive in a
> let-bound unread-command-events and not taking all of it out before
> unbinding.
>
> But at least most of the other opportunities for dropping
> events/characters are addressed by this patch.

Barring any comments, I am going to push this patch to master, probably
by tomorrow.  It does not fix the main lossage of events pushed into
unread-command-events (which is likely the fault of some code in
src/keyboard.c and also keeps the events from appearing in a dribble
file even though their keymap actions are executed).  But it reduces the
amount of stuff one has to worry about.

-- 
David Kastrup