[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Deal gracefully with up-events (Bug#19746)

From: Stefan Monnier
Subject: Re: [PATCH] Deal gracefully with up-events (Bug#19746)
Date: Mon, 10 Aug 2015 17:58:41 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

> * keyboard.c (apply_modifiers_uncached, parse_solitary_modifier)
> (parse_modifiers_uncached): React gracefully to "up-" modifiers:
> those may easily be injected by user-level Lisp code.
> (read_key_sequence): Discard unbound up-events like unbound
> down-events: they are even more likely only relevant for special
> purposes.

Looks good.

> While Emacs will not produce up-events on its own currently (those are
> converted to drag or click events before being converted to
> Lisp-readable structures), the input queue can be made to contain them
> by synthesizing events to `unread-command-events'.  Emacs should deal
> consistently with such events.

This probably belongs in a comment rather than in the ChangeLog.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]