Re: [Emacs-diffs] master d7df36e: Rewrite elisp--xref-find-definitions to handle many more cases; add tests.

[Stephen Leake]

Stefan Monnier <address@hidden> writes:

>>> -(defvar elisp--xref-format
>>> +(defconst elisp--xref-format
>>> (let ((str "(%s %s)"))
>>> (put-text-property 1 3 'face 'font-lock-keyword-face str)
>>> (put-text-property 4 6 'face 'font-lock-function-name-face str)
>>> str))
>
>> I'm not sure which part of the change did that, but now I don't see the
>> colors in the output.
>
> I can shed some light here:
> - because it's now a defconst, the value is purecopy'd (since
>   elisp-mode is preloaded).
> - purecopy currently doesn't know how to copy string's text properties
>   so they're just thrown away.

> and the better fix would be to improve purecopy to not throw away
> those properties.

I filed bug#21237 for this.

In the meantime, we could at least document this behavior in the
defconst docstring.

Can we add a warning somewhere in the load/dump process for this?

-- 
-- Stephe