[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [elpa] master b843370: * packages/other-frame-window/other-frame-win

From: Stefan Monnier
Subject: Re: [elpa] master b843370: * packages/other-frame-window/other-frame-window.el: New single-file package.
Date: Sat, 15 Aug 2015 17:50:03 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

>     ;; FIXME: This is basically the union of the default C-x 4 and C-x 5
>     ;; keymaps in Emacs-25.
> Is the point of this FIXME: that eventually this could replace the C-x 4
> and C-x 5 keymaps?

Good question.  I think it was a mistake.  I probably started to write
"FIXME:" because I wanted to document the problem of the "dwim"
commands, which are somewhat ugly, but then I went ahead and wrote
those dwim commands and decided it wasn't that bad.  So the end result
is a doc that isn't really a FIXME but which starts with "FIXME:".

> - Why is (remove-hook 'pre-command-hook #'ofw--reset-prefix) before the
>   'if', instead of in the else branch?

I like to write minor modes such that they always begin by cleaning up
first and then, if requested, adding what needs to be added.
I think in the case of global hooks it makes no difference, but for
a few other cases it avoids adding stuff twice or having to check
whether the mode was already enabled or something.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]