[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Handle output from Emacs byte-compilation properly

From: Jostein Kjønigsen
Subject: Re: [PATCH] Handle output from Emacs byte-compilation properly
Date: Mon, 14 Sep 2015 22:24:56 +0200

The previous patch is not  a good one and there's an error in it. Please
the previous patch and consider the attached patch instead.

You'll have to take my word for it when I say I -did- test it before
submitting. :)

Jostein Kjønigsen
address@hidden / address@hidden

On Mon, Sep 14, 2015, at 10:14 PM, Jostein Kjønigsen wrote:
> It's common for module-developers to run Emacs byte-compilation in
> separate build-scripts.
> When invoking byte-compile on Emacs-lisp files you often get the
> following headers:
> - In toplevel form:
> - In end of data:
> When these errors show up in the output of a build-script initiated
> through M-x compile and show up in a compilation-mode buffer, these
> lines gets treated as guile-errors for files which doesn't exist.
> This is due to the following regexp, which is quite frankly extremely
> wide:
>     (guile-file "^In \\(.+\\):\n" 1)
> This breaks prev-error and next-error based navigation because the
> files "toplevel form" and "end of data" doesn't exist.
> This patch ensures those lines are treated as information only before
> getting to the guile-file regexp.
> --
> Jostein Kjønigsen
> address@hidden / address@hidden
> Email had 1 attachment:

> * compilation-mode-emacs-lisp.patch
>   2k (text/x-patch)

Attachment: compilation-mode-emacs-lisp.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]