[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations whe
From: |
Eli Zaretskii |
Subject: |
Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay |
Date: |
Sun, 04 Oct 2015 12:53:18 +0300 |
> From: Stefan Monnier <address@hidden>
> Cc: address@hidden
> Date: Sat, 03 Oct 2015 22:33:06 -0400
>
> > Tell you what: if you add commentary that describes the logic of using
> > these two variables, the window's and frame's 'redisplay' flags, and
> > how all those are used to decide which parts need to be redisplayed,
> > and if that commentary makes it clear that the code I added is
> > redundant, I will remove the code I added, and see if some alternative
> > design would be better. Deal?
>
> How do you like the patch below?
I like it very much, thanks! Please commit.
Bonus points for adding something that describes where these variables
and the corresponding 'redisplay' flags are checked, because the
FOR_EACH_FRAME loop in redisplay_internal doesn't look at the
'redisplay' flags, so a large part of the logic you describe above
isn't (easily) visible at that level.
- Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay, Stefan Monnier, 2015/10/08
- Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay, Eli Zaretskii, 2015/10/08
- Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay, Stefan Monnier, 2015/10/08
- Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay, Eli Zaretskii, 2015/10/08
- Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay, Stefan Monnier, 2015/10/08
- Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay, Eli Zaretskii, 2015/10/08
- Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay, Stefan Monnier, 2015/10/08
- Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay, Eli Zaretskii, 2015/10/08
- Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay, Stefan Monnier, 2015/10/08
- Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay,
Eli Zaretskii <=
- Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay, Stefan Monnier, 2015/10/08
- Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay, Eli Zaretskii, 2015/10/08
- Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay, Stefan Monnier, 2015/10/08
- Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay, martin rudalics, 2015/10/08
- Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay, Stefan Monnier, 2015/10/08
- Re: [Emacs-diffs] master 5c9304e: Disable some display optimizations when frames need redisplay, Stefan Monnier, 2015/10/08