[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fix/ert-multiline-explanation
From: |
Eli Zaretskii |
Subject: |
Re: fix/ert-multiline-explanation |
Date: |
Mon, 26 Oct 2015 17:57:19 +0200 |
> From: address@hidden (Phillip Lord)
> Cc: <address@hidden>
> Date: Mon, 26 Oct 2015 08:55:12 +0000
>
> F with
> (ert-test-failed
> ((should
> (silly-predicate
> (advice-add 'ert--pp-with-indentation-and-newline :around
> #'sisyphus--ert-pp-with-indentation-and-newline)))
> :form
> (silly-predicate nil)
> :value nil :explanation "Silly predicate is silly.
> I mean, it's in the name, so why are you using it?
> It's never going to return a sensible answer.
> It is after silly.
> ^^^^^"))
>
> F without
> (ert-test-failed
> ((should
> (silly-predicate
> (advice-remove 'ert--pp-with-indentation-and-newline
> #'sisyphus--ert-pp-with-indentation-and-newline)))
> :form
> (silly-predicate nil)
> :value nil :explanation "Silly predicate is silly.\nI mean, it's in the
> name, so why are you using it?\nIt's never going to return a sensible
> answer.\nIt is after silly.\n ^^^^^"))
Looks like your change is a clear improvement, so please install.
Thanks.
Re: fix/ert-multiline-explanation, Eli Zaretskii, 2015/10/24