[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Separating obarray handling from abbrevs

From: Artur Malabarba
Subject: Re: Separating obarray handling from abbrevs
Date: Sun, 08 Nov 2015 21:05:36 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

Przemysław Wojnowski <address@hidden> writes:

> I've extracted basic obarray functionality from abbrev.el into separate
> file (the first patch).

I kinda failed to see the point of this originally, but looking at the
diff I can tell this is a good idea.™

> +(defun obarray-make (&optional size)
> +  "Return a new obarray of size `SIZE' or `obarray-default-size'."

Use SIZE, not `SIZE'. Similarly everywhere else.

> +(defun obarray-get (obarray name)
> +  "Return from obarray `OBARRAY' symbol with `NAME' or nil."

I'd use:
"Return symbol named NAME if it is contained in OBARRAY.
Return nil otherwise."

And I would repeat this throughout the docstrings.

> +(defun obarray-put (obarray name)
> +  "Return form `OBARRAY' symbol with `NAME' or nil.

Why the nil?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]