[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master a3b2101 1/2: New file with obarray functions.

From: Przemysław Wojnowski
Subject: Re: [Emacs-diffs] master a3b2101 1/2: New file with obarray functions.
Date: Wed, 11 Nov 2015 22:22:02 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

W dniu 11.11.2015 o 21:26, Stefan Monnier pisze:
     New file with obarray functions.
     * lisp/obarray.el: basic obarray functions extracted from abbrev.el
     * test/automated/obarray-tests.el: new file

Funnily enough, I think we should discourage the use of obarrays.
There are times/places where they are really indispensable (when we
really need to handle *symbols*), but in the majority of cases where
I could see this obarray.el being used, a hash-table would work better
(e.g. hash-table-p is more reliable, print+read actually works, access
is usually faster, ...).


Thanks for feedback.

I just extracted obarray functionality from abbrev.el. This separates abbrev responsibility from underlying collection type to make both easier to test, understand and change if needed. Replace of implementation was not purpose of this commit.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]