Re: Fixing compilation and byte-compilation warnings before 25.1

[Andy Moreton]

On Fri 13 Nov 2015, daniel sutton wrote:

> Hello everyone. I'm a bit new to mucking about in the internals of emacs
> but wanted to help out with cleaning up some compiler and byte compiler
> warnings.
>
> I'm building and noticing the error
> minibuffer.el:1697:12 display-completion-list called with 2 arguments but
> accepts only 1.
>
> I'm a little confused as the this function has this signature:
> (defun display-completion-list (completions &optional common-substring) ...)
> In fact, this is a recursive call inside of the function
> display-completion-list.
>
> Can someone help me understand why we are getting a compiler warning about
> seemingly valid usage of optional arguments?

Look at the advertised-calling-convention form at the start of the
function. The calling convention has changed, and the optional argument
has been removed. See (info "(elisp) Declare Form").

    AndyM