[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fixing compilation and byte-compilation warnings before 25.1

From: Artur Malabarba
Subject: Re: Fixing compilation and byte-compilation warnings before 25.1
Date: Mon, 16 Nov 2015 23:24:30 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

daniel sutton <address@hidden> writes:

> My thinking is that we may have local definitions of
> byte-compile-enable-warnings that include (not callargs) *only* when
> compiling a function that contains a (declare
> (advertised-calling-convention (newArgs) "version")).

This wouldn't do.
This would mean that you would never get a callargs warning inside a
function that declares `advertised-calling-convention', _even_ warnings
that pertain to calls to _other_ functions. 

So it would have to be smarter than that, and only suppress the warning
if it pertains to this very function.

> Again, this is a proposal only for this specific type of warning, and
> not just suppressing warnings inside of the core. I want warnings to
> be informative and a cause of action, not to be ignored. This warning
> is superfluous and should be removed. If the best case is just a
> (with-no-warnings ...) so be it, but I think there is a more clever
> solution here, and one that actually fits the nature of what is being
> done with a advertised-calling-convention change.

You should know, I don't think this sitation of “function with obsolete
calling convention that recursively calls itself” is actually that

If you'd like to try your hand at this, by all means, have fun. :-)
The cause sounds reasonable to me, as long as the solution doesn't
turn out horribly complex it should be a nice addition.
I just thought you should know that.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]